-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[FIX] conf.py: check odoo_dir is a real Odoo sources dir #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with the change but, since we keep patching the patch that allows building the doc on any setup, I also think it's time to introduce a config option to specify the odoo sources paths. It would look like this in the CLI: make ODOO_SOURCE_PATH=../odoo. If not passed, the default should be odoo to avoid breaking current setups. I'll create a task to do it later.
I tried to do that but, as far as I know, in the Thanks for the review, I will update the PR ;-) |
You need to declare it in |
d01f52d to
2b36476
Compare
So, after some tests, unfortunately, it's not so easy to dynamically configure extensions in But, in fact, we have 2 use cases:
|
In `conf.py`, we try to find a Odoo sources folder among `odoo` and `../odoo` directories without really checking that they really are Odoo sources folders, leading to doc generation error if it's not the case. So, to improve that, this commit checks that the selected Odoo sources folder contains `odoo-bin`. While we're at it, the logging is also improved to always display the matching odoo sources' folder and version. Co-authored-by: Antoine Vandevenne <anv@odoo.com>
2b36476 to
0e96c53
Compare
|
LGTM! FYI: I took the liberty to improve the logging messages a bit, now that it's clear that we support alternative odoo sources paths. @robodoo r+ |
In `conf.py`, we try to find a Odoo sources folder among `odoo` and `../odoo` directories without really checking that they really are Odoo sources folders, leading to doc generation error if it's not the case. So, to improve that, this commit checks that the selected Odoo sources folder contains `odoo-bin`. While we're at it, the logging is also improved to always display the matching odoo sources' folder and version. closes #1333 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Co-authored-by: Antoine Vandevenne <anv@odoo.com>
In
conf.py, we try to find a Odoo sources folder amongodooand../odoodirectories without really checking that they really areOdoo sources folders, leading to doc generation error if it's not the case.
So, to improve that, this commit checks that the selected Odoo sources folder contains
odoo-bin.